libnm: accept invalid connections in NMSecretAgentOld

When we receive a connection from NetworkManager it is not guaranteed
that the connection verifies. For example, if the current libnm version
is older then the NetworkManager version.

Be more accepting and don't do any verification of the connection.

This is a change in behavior in that we accept also invalid connections
and pass them down to the sub-classes.

diff --git a/libnm/nm-secret-agent-old.c b/libnm/nm-secret-agent-old.c
index 8edb224..60b7a62 100644 (file)
--- a/libnm/nm-secret-agent-old.c
+++ b/libnm/nm-secret-agent-old.c
@@ -27,6 +27,7 @@
 #include "nm-enum-types.h"
 #include "nm-dbus-helpers.h"
 #include "nm-simple-connection.h"
+#include "nm-core-internal.h"
 
 #include "nmdbus-secret-agent.h"
 #include "nmdbus-agent-manager.h"
@@ -273,7 +274,7 @@ verify_request (NMSecretAgentOld *self,
 
        /* Make sure the given connection is valid */
        g_assert (out_connection);
-       connection = nm_simple_connection_new_from_dbus (connection_dict, &local);
+       connection = _nm_simple_connection_new_from_dbus (connection_dict, NM_SETTING_PARSE_FLAGS_BEST_EFFORT, &local);
        if (connection) {
                nm_connection_set_path (connection, connection_path);
                *out_connection = connection;