From 9a31bbcbc398568a065e0f3d48c0dfce7eddcef7 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 23 Mar 2016 15:32:43 +0100 Subject: [PATCH] libnm: accept invalid connections in NMSecretAgentOld When we receive a connection from NetworkManager it is not guaranteed that the connection verifies. For example, if the current libnm version is older then the NetworkManager version. Be more accepting and don't do any verification of the connection. This is a change in behavior in that we accept also invalid connections and pass them down to the sub-classes. --- libnm/nm-secret-agent-old.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libnm/nm-secret-agent-old.c b/libnm/nm-secret-agent-old.c index 8edb224cb..60b7a624e 100644 --- a/libnm/nm-secret-agent-old.c +++ b/libnm/nm-secret-agent-old.c @@ -27,6 +27,7 @@ #include "nm-enum-types.h" #include "nm-dbus-helpers.h" #include "nm-simple-connection.h" +#include "nm-core-internal.h" #include "nmdbus-secret-agent.h" #include "nmdbus-agent-manager.h" @@ -273,7 +274,7 @@ verify_request (NMSecretAgentOld *self, /* Make sure the given connection is valid */ g_assert (out_connection); - connection = nm_simple_connection_new_from_dbus (connection_dict, &local); + connection = _nm_simple_connection_new_from_dbus (connection_dict, NM_SETTING_PARSE_FLAGS_BEST_EFFORT, &local); if (connection) { nm_connection_set_path (connection, connection_path); *out_connection = connection; -- 2.17.1