libnm: don't normalize connection for nm_device_get_applied_connection()
authorThomas Haller <thaller@redhat.com>
Thu, 17 Mar 2016 09:37:42 +0000 (10:37 +0100)
committerThomas Haller <thaller@redhat.com>
Sat, 26 Mar 2016 11:10:54 +0000 (12:10 +0100)
Normalizing means that we fail on invalid connections.
Which can happen when the server is newer than the libnm
version. We just want to return whatever we can. The
caller should make sense of this.

This makes libnm more accepting and thus is not going to break
existing applications. Also, nm_device_get_applied_connection()
is new API since nm-1-1.

libnm/nm-device.c

index 81077be..5679fd5 100644 (file)
@@ -2355,7 +2355,7 @@ nm_device_get_applied_connection (NMDevice *device,
                return NULL;
        }
 
-       connection = nm_simple_connection_new_from_dbus (dict, error);
+       connection = _nm_simple_connection_new_from_dbus (dict, NM_SETTING_PARSE_FLAGS_BEST_EFFORT, error);
        if (!connection)
                return NULL;
 
@@ -2397,7 +2397,7 @@ device_get_applied_connection_cb (GObject *proxy,
                goto out;
        }
 
-       connection = nm_simple_connection_new_from_dbus (dict, &error);
+       connection = _nm_simple_connection_new_from_dbus (dict, NM_SETTING_PARSE_FLAGS_BEST_EFFORT, &error);
        if (!connection) {
                g_simple_async_result_take_error (simple, error);
                goto out;