Check for bad nameservers

diff --git a/bind8/lang/en b/bind8/lang/en
index 61de74b..3955683 100644 (file)
--- a/bind8/lang/en
+++ b/bind8/lang/en
@@ -883,6 +883,7 @@ add_echeck=Server $1 does not have the BIND DNS Server module.
 add_emissing=Server $1 does not have BIND setup properly.
 add_eversion=Server $1 is not running Webmin version $2 or above.
 add_eversion2=Server $1 is not running Webmin version $2 or above, which is needed to add zones to more than one view
+add_eipaddr=Server $1 has an IP address instead of a hostname
 add_ok=Added $1, with $2 existing zones.
 add_eview=Missing view names
 add_createerr=Setup $1 with $2 new slave zones, but encountered $3 errors :

diff --git a/bind8/slave_add.cgi b/bind8/slave_add.cgi
index b433414..c58a8a1 100755 (executable)
--- a/bind8/slave_add.cgi
+++ b/bind8/slave_add.cgi
@@ -73,6 +73,17 @@ foreach $s (@add) {
        if ($s->{'bind8_view'} && $s->{'bind8_view'} =~ /\s/ &&
            $rver < 1.422) {
                print &text('add_eversion2', $s->{'host'}, 1.422),"<p>\n";
+               next;
+               }
+
+       # Check for non-IP name
+       if (&check_ipaddress($s->{'host'}) && $in{'name_def'}) {
+               print &text('add_eipaddr', $s->{'host'}),"<p>\n";
+               next;
+               }
+       if (!$in{'name_def'} && &check_ipaddress($in{'name'})) {
+               print &text('add_eipaddr', $s->{'host'}),"<p>\n";
+               next;
                }
 
        @rzones = grep { $_->{'type'} ne 'view' }