Fix directory creation for scheduled backups, and create as the right owner

diff --git a/postgresql/backup.cgi b/postgresql/backup.cgi
index 24687ca..193f80a 100755 (executable)
--- a/postgresql/backup.cgi
+++ b/postgresql/backup.cgi
@@ -105,7 +105,7 @@ if (!$in{'save'}) {
                        }
                if ($in{'all'}) {
                        $dir = &date_subs($in{'path'});
-                       &make_dir($dir, 0755) if ($in{'mkdir'});
+                       &make_backup_dir($dir) if ($in{'mkdir'});
                        $path = $dir."/".$db.".".$suf;
                        }
                else {

diff --git a/postgresql/backup.pl b/postgresql/backup.pl
index 6fa93af..71ee70a 100755 (executable)
--- a/postgresql/backup.pl
+++ b/postgresql/backup.pl
@@ -32,10 +32,13 @@ foreach $db (@dbs) {
                next;
                }
        $format = $config{'backup_format_'.$sf};
+       $mkdir = $config{'backup_mkdir_'.$sf};
        $suf = $format eq "p" ? "sql" :
               $format eq "t" ? "tar" : "post";
        if ($all) {
-               $file = &date_subs("$config{'backup_'}/$db.$suf");
+               $dir = &date_subs($config{'backup_'});
+               $file = "$dir/$db.$suf";
+               &make_backup_dir($dir) if ($mkdir);
                }
        else {
                $file = &date_subs($config{'backup_'.$db});

diff --git a/postgresql/postgresql-lib.pl b/postgresql/postgresql-lib.pl
index 1893975..554c297 100755 (executable)
--- a/postgresql/postgresql-lib.pl
+++ b/postgresql/postgresql-lib.pl
@@ -754,6 +754,19 @@ if ($cmd) {
 return 1;
 }
 
+# make_backup_dir(directory)
+# Create a directory that PostgreSQL can backup into
+sub make_backup_dir
+{
+local ($dir) = @_;
+if (!-d $dir) {
+       &make_dir($dir, 0755);
+       if ($postgres_sameunix && defined(getpwnam($postgres_login))) {
+               &set_ownership_permissions($postgres_login, undef, undef, $dir);
+               }
+       }
+}
+
 sub quote_table
 {
 local @tn = split(/\./, $_[0]);