projects
/
NetworkManager.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a77ec45
)
fake-platform: check link_get return
author
Lubomir Rintel
<lkundrak@v3.sk>
Fri, 29 Jan 2016 08:49:06 +0000
(09:49 +0100)
committer
Lubomir Rintel
<lkundrak@v3.sk>
Fri, 29 Jan 2016 19:18:22 +0000
(20:18 +0100)
Can not fail no fake platform, but makes Coverity worried:
CID 59381 (#1 of 1): Dereference null return value (NULL_RETURNS)
6. dereference: Dereferencing a null pointer device.
src/platform/nm-fake-platform.c
patch
|
blob
|
history
diff --git
a/src/platform/nm-fake-platform.c
b/src/platform/nm-fake-platform.c
index
a4eae90
..
7fef696
100644
(file)
--- a/
src/platform/nm-fake-platform.c
+++ b/
src/platform/nm-fake-platform.c
@@
-509,7
+509,8
@@
link_set_address (NMPlatform *platform, int ifindex, gconstpointer addr, size_t
{
NMFakePlatformLink *device = link_get (platform, ifindex);
- if ( len == 0
+ if ( !device
+ || len == 0
|| len > NM_UTILS_HWADDR_LEN_MAX
|| !addr)
g_return_val_if_reached (FALSE);