manager: don't proceed with activation when there's no master device
authorLubomir Rintel <lkundrak@v3.sk>
Wed, 17 Feb 2016 11:05:45 +0000 (12:05 +0100)
committerLubomir Rintel <lkundrak@v3.sk>
Wed, 17 Feb 2016 18:04:05 +0000 (19:04 +0100)
Since the device-for-all merge it's a sin (trips an assert) to create an
activation request with NULL device.

If we get here, it's probably that the master device exists, but is not ready
for activation (it's in UNMANAGED state in the process of being created).

src/nm-manager.c

index 589fc10..648faf4 100644 (file)
@@ -2564,21 +2564,6 @@ ensure_master_active_connection (NMManager *self,
                        return master_ac;
                }
 
-               /* Device described by master_connection may be a virtual one that's
-                * not created yet.
-                */
-               if (!found_device && nm_connection_is_virtual (NM_CONNECTION (master_connection))) {
-                       master_ac = nm_manager_activate_connection (self,
-                                                                   master_connection,
-                                                                   NULL,
-                                                                   NULL,
-                                                                   subject,
-                                                                   error);
-                       if (!master_ac)
-                               g_prefix_error (error, "%s", "Master device activation failed: ");
-                       return master_ac;
-               }
-
                g_set_error (error,
                             NM_MANAGER_ERROR,
                             NM_MANAGER_ERROR_UNKNOWN_DEVICE,