all: cleanup includes and let "nm-default.h" include "config.h"
authorThomas Haller <thaller@redhat.com>
Fri, 19 Feb 2016 13:57:48 +0000 (14:57 +0100)
committerThomas Haller <thaller@redhat.com>
Fri, 19 Feb 2016 16:53:25 +0000 (17:53 +0100)
commit8bace23bebcc28396460663203d54aac4ec8ffbf
tree1655434d48980dbb4a547f6d56a231252aa0181d
parent89d6fa6aa93cdc982992c137f0b694cd339c315c
all: cleanup includes and let "nm-default.h" include "config.h"

- All internal source files (except "examples", which are not internal)
  should include "config.h" first. As also all internal source
  files should include "nm-default.h", let "config.h" be included
  by "nm-default.h" and include "nm-default.h" as first in every
  source file.
  We already wanted to include "nm-default.h" before other headers
  because it might contains some fixes (like "nm-glib.h" compatibility)
  that is required first.

- After including "nm-default.h", we optinally allow for including the
  corresponding header file for the source file at hand. The idea
  is to ensure that each header file is self contained.

- Don't include "config.h" or "nm-default.h" in any header file
  (except "nm-sd-adapt.h"). Public headers anyway must not include
  these headers, and internal headers are never included after
  "nm-default.h", as of the first previous point.

- Include all internal headers with quotes instead of angle brackets.
  In practice it doesn't matter, because in our public headers we must
  include other headers with angle brackets. As we use our public
  headers also to compile our interal source files, effectively the
  result must be the same. Still do it for consistency.

- Except for <config.h> itself. Include it with angle brackets as suggested by
  https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
437 files changed:
callouts/nm-dispatcher-utils.c
callouts/nm-dispatcher.c
callouts/tests/test-dispatcher-envp.c
clients/cli/agent.c
clients/cli/common.c
clients/cli/connections.c
clients/cli/devices.c
clients/cli/general.c
clients/cli/nmcli.c
clients/cli/nmcli.h
clients/cli/polkit-agent.c
clients/cli/settings.c
clients/cli/utils.c
clients/common/nm-polkit-listener.c
clients/common/nm-secret-agent-simple.c
clients/common/nm-vpn-helpers.c
clients/nm-online.c
clients/tui/newt/nmt-newt-button-box.c
clients/tui/newt/nmt-newt-button.c
clients/tui/newt/nmt-newt-checkbox.c
clients/tui/newt/nmt-newt-component.c
clients/tui/newt/nmt-newt-container.c
clients/tui/newt/nmt-newt-entry-numeric.c
clients/tui/newt/nmt-newt-entry.c
clients/tui/newt/nmt-newt-form.c
clients/tui/newt/nmt-newt-grid.c
clients/tui/newt/nmt-newt-hacks.c
clients/tui/newt/nmt-newt-hacks.h
clients/tui/newt/nmt-newt-label.c
clients/tui/newt/nmt-newt-listbox.c
clients/tui/newt/nmt-newt-popup.c
clients/tui/newt/nmt-newt-section.c
clients/tui/newt/nmt-newt-separator.c
clients/tui/newt/nmt-newt-stack.c
clients/tui/newt/nmt-newt-textbox.c
clients/tui/newt/nmt-newt-toggle-button.c
clients/tui/newt/nmt-newt-utils.c
clients/tui/newt/nmt-newt-widget.c
clients/tui/nm-editor-bindings.c
clients/tui/nm-editor-utils.c
clients/tui/nmt-address-list.c
clients/tui/nmt-connect-connection-list.c
clients/tui/nmt-device-entry.c
clients/tui/nmt-edit-connection-list.c
clients/tui/nmt-editor-grid.c
clients/tui/nmt-editor-page-device.c
clients/tui/nmt-editor-page.c
clients/tui/nmt-editor-section.c
clients/tui/nmt-editor.c
clients/tui/nmt-ip-entry.c
clients/tui/nmt-mac-entry.c
clients/tui/nmt-mtu-entry.c
clients/tui/nmt-page-bond.c
clients/tui/nmt-page-bridge-port.c
clients/tui/nmt-page-bridge.c
clients/tui/nmt-page-dsl.c
clients/tui/nmt-page-ethernet.c
clients/tui/nmt-page-infiniband.c
clients/tui/nmt-page-ip4.c
clients/tui/nmt-page-ip6.c
clients/tui/nmt-page-ppp.c
clients/tui/nmt-page-team-port.c
clients/tui/nmt-page-team.c
clients/tui/nmt-page-vlan.c
clients/tui/nmt-page-wifi.c
clients/tui/nmt-password-dialog.c
clients/tui/nmt-password-fields.c
clients/tui/nmt-route-editor.c
clients/tui/nmt-route-entry.c
clients/tui/nmt-route-table.c
clients/tui/nmt-slave-list.c
clients/tui/nmt-utils.c
clients/tui/nmt-widget-list.c
clients/tui/nmtui-connect.c
clients/tui/nmtui-edit.c
clients/tui/nmtui-hostname.c
clients/tui/nmtui.c
examples/C/glib/add-connection-gdbus.c
examples/C/glib/add-connection-libnm.c
examples/C/glib/get-active-connections-gdbus.c
examples/C/glib/get-ap-info-libnm.c
examples/C/glib/list-connections-gdbus.c
examples/C/glib/list-connections-libnm.c
examples/C/glib/monitor-nm-running-gdbus.c
examples/C/glib/monitor-nm-state-gdbus.c
libnm-core/crypto.c
libnm-core/crypto_gnutls.c
libnm-core/crypto_nss.c
libnm-core/nm-connection.c
libnm-core/nm-dbus-utils.c
libnm-core/nm-errors.c
libnm-core/nm-keyfile-reader.c
libnm-core/nm-keyfile-utils.c
libnm-core/nm-keyfile-writer.c
libnm-core/nm-property-compare.c
libnm-core/nm-setting-8021x.c
libnm-core/nm-setting-adsl.c
libnm-core/nm-setting-bluetooth.c
libnm-core/nm-setting-bond.c
libnm-core/nm-setting-bridge-port.c
libnm-core/nm-setting-bridge.c
libnm-core/nm-setting-cdma.c
libnm-core/nm-setting-connection.c
libnm-core/nm-setting-dcb.c
libnm-core/nm-setting-generic.c
libnm-core/nm-setting-gsm.c
libnm-core/nm-setting-infiniband.c
libnm-core/nm-setting-ip-config.c
libnm-core/nm-setting-ip-tunnel.c
libnm-core/nm-setting-ip4-config.c
libnm-core/nm-setting-ip6-config.c
libnm-core/nm-setting-macvlan.c
libnm-core/nm-setting-olpc-mesh.c
libnm-core/nm-setting-ppp.c
libnm-core/nm-setting-pppoe.c
libnm-core/nm-setting-serial.c
libnm-core/nm-setting-team-port.c
libnm-core/nm-setting-team.c
libnm-core/nm-setting-tun.c
libnm-core/nm-setting-vlan.c
libnm-core/nm-setting-vpn.c
libnm-core/nm-setting-vxlan.c
libnm-core/nm-setting-wimax.c
libnm-core/nm-setting-wired.c
libnm-core/nm-setting-wireless-security.c
libnm-core/nm-setting-wireless.c
libnm-core/nm-setting.c
libnm-core/nm-simple-connection.c
libnm-core/nm-utils.c
libnm-core/nm-vpn-editor-plugin.c
libnm-core/nm-vpn-plugin-info.c
libnm-core/tests/test-compare.c
libnm-core/tests/test-crypto.c
libnm-core/tests/test-general.c
libnm-core/tests/test-keyfile.c
libnm-core/tests/test-secrets.c
libnm-core/tests/test-setting-8021x.c
libnm-core/tests/test-setting-dcb.c
libnm-core/tests/test-settings-defaults.c
libnm-glib/libnm-glib-test.c
libnm-glib/libnm_glib.c
libnm-glib/nm-access-point.c
libnm-glib/nm-active-connection.c
libnm-glib/nm-client.c
libnm-glib/nm-dbus-helpers.c
libnm-glib/nm-device-adsl.c
libnm-glib/nm-device-bond.c
libnm-glib/nm-device-bridge.c
libnm-glib/nm-device-bt.c
libnm-glib/nm-device-ethernet.c
libnm-glib/nm-device-generic.c
libnm-glib/nm-device-infiniband.c
libnm-glib/nm-device-modem.c
libnm-glib/nm-device-olpc-mesh.c
libnm-glib/nm-device-team.c
libnm-glib/nm-device-vlan.c
libnm-glib/nm-device-wifi.c
libnm-glib/nm-device-wimax.c
libnm-glib/nm-device.c
libnm-glib/nm-dhcp4-config.c
libnm-glib/nm-dhcp6-config.c
libnm-glib/nm-ip4-config.c
libnm-glib/nm-ip6-config.c
libnm-glib/nm-object-cache.c
libnm-glib/nm-object.c
libnm-glib/nm-remote-connection.c
libnm-glib/nm-remote-settings.c
libnm-glib/nm-secret-agent.c
libnm-glib/nm-types.c
libnm-glib/nm-vpn-connection.c
libnm-glib/nm-vpn-plugin-ui-interface.c
libnm-glib/nm-vpn-plugin-utils.c
libnm-glib/nm-vpn-plugin.c
libnm-glib/nm-wimax-nsp.c
libnm-glib/tests/test-nm-client.c
libnm-glib/tests/test-remote-settings-client.c
libnm-util/crypto.c
libnm-util/crypto_gnutls.c
libnm-util/crypto_nss.c
libnm-util/nm-connection.c
libnm-util/nm-param-spec-specialized.c
libnm-util/nm-setting-8021x.c
libnm-util/nm-setting-adsl.c
libnm-util/nm-setting-bluetooth.c
libnm-util/nm-setting-bond.c
libnm-util/nm-setting-bridge-port.c
libnm-util/nm-setting-bridge.c
libnm-util/nm-setting-cdma.c
libnm-util/nm-setting-connection.c
libnm-util/nm-setting-dcb.c
libnm-util/nm-setting-generic.c
libnm-util/nm-setting-gsm.c
libnm-util/nm-setting-infiniband.c
libnm-util/nm-setting-ip4-config.c
libnm-util/nm-setting-ip6-config.c
libnm-util/nm-setting-olpc-mesh.c
libnm-util/nm-setting-ppp.c
libnm-util/nm-setting-pppoe.c
libnm-util/nm-setting-serial.c
libnm-util/nm-setting-team-port.c
libnm-util/nm-setting-team.c
libnm-util/nm-setting-template.c
libnm-util/nm-setting-vlan.c
libnm-util/nm-setting-vpn.c
libnm-util/nm-setting-wimax.c
libnm-util/nm-setting-wired.c
libnm-util/nm-setting-wireless-security.c
libnm-util/nm-setting-wireless.c
libnm-util/nm-setting.c
libnm-util/nm-utils.c
libnm-util/nm-value-transforms.c
libnm-util/tests/test-crypto.c
libnm-util/tests/test-general.c
libnm-util/tests/test-libnm-linking.c
libnm-util/tests/test-secrets.c
libnm-util/tests/test-setting-8021x.c
libnm-util/tests/test-setting-dcb.c
libnm-util/tests/test-settings-defaults.c
libnm/nm-access-point.c
libnm/nm-active-connection.c
libnm/nm-client.c
libnm/nm-dbus-helpers.c
libnm/nm-device-adsl.c
libnm/nm-device-bond.c
libnm/nm-device-bridge.c
libnm/nm-device-bt.c
libnm/nm-device-ethernet.c
libnm/nm-device-generic.c
libnm/nm-device-infiniband.c
libnm/nm-device-ip-tunnel.c
libnm/nm-device-macvlan.c
libnm/nm-device-modem.c
libnm/nm-device-olpc-mesh.c
libnm/nm-device-team.c
libnm/nm-device-tun.c
libnm/nm-device-vlan.c
libnm/nm-device-vxlan.c
libnm/nm-device-wifi.c
libnm/nm-device-wimax.c
libnm/nm-device.c
libnm/nm-dhcp-config.c
libnm/nm-dhcp4-config.c
libnm/nm-dhcp6-config.c
libnm/nm-ip-config.c
libnm/nm-ip4-config.c
libnm/nm-ip6-config.c
libnm/nm-manager.c
libnm/nm-object-cache.c
libnm/nm-object.c
libnm/nm-remote-connection.c
libnm/nm-remote-settings.c
libnm/nm-secret-agent-old.c
libnm/nm-vpn-connection.c
libnm/nm-vpn-editor.c
libnm/nm-vpn-plugin-old.c
libnm/nm-vpn-service-plugin.c
libnm/nm-wimax-nsp.c
libnm/tests/test-nm-client.c
libnm/tests/test-remote-settings-client.c
libnm/tests/test-secret-agent.c
shared/nm-default.h
shared/nm-test-utils-impl.c
src/NetworkManagerUtils.c
src/devices/adsl/nm-atm-manager.c
src/devices/adsl/nm-device-adsl.c
src/devices/bluetooth/nm-bluez-common.h
src/devices/bluetooth/nm-bluez-device.c
src/devices/bluetooth/nm-bluez-device.h
src/devices/bluetooth/nm-bluez-manager.c
src/devices/bluetooth/nm-bluez4-adapter.c
src/devices/bluetooth/nm-bluez4-manager.c
src/devices/bluetooth/nm-bluez5-dun.c
src/devices/bluetooth/nm-bluez5-manager.c
src/devices/bluetooth/nm-bt-error.c
src/devices/bluetooth/nm-device-bt.c
src/devices/nm-arping-manager.c
src/devices/nm-device-bond.c
src/devices/nm-device-bridge.c
src/devices/nm-device-ethernet-utils.c
src/devices/nm-device-ethernet.c
src/devices/nm-device-factory.c
src/devices/nm-device-generic.c
src/devices/nm-device-infiniband.c
src/devices/nm-device-ip-tunnel.c
src/devices/nm-device-macvlan.c
src/devices/nm-device-tun.c
src/devices/nm-device-veth.c
src/devices/nm-device-vlan.c
src/devices/nm-device-vxlan.c
src/devices/nm-device.c
src/devices/nm-lldp-listener.c
src/devices/team/nm-device-team.c
src/devices/team/nm-team-factory.c
src/devices/tests/test-arping.c
src/devices/tests/test-lldp.c
src/devices/wifi/nm-device-olpc-mesh.c
src/devices/wifi/nm-device-wifi.c
src/devices/wifi/nm-wifi-ap-utils.c
src/devices/wifi/nm-wifi-ap.c
src/devices/wifi/nm-wifi-factory.c
src/devices/wifi/tests/test-wifi-ap-utils.c
src/devices/wwan/nm-device-modem.c
src/devices/wwan/nm-modem-broadband.c
src/devices/wwan/nm-modem-manager.c
src/devices/wwan/nm-modem.c
src/devices/wwan/nm-wwan-factory.c
src/dhcp-manager/nm-dhcp-client.c
src/dhcp-manager/nm-dhcp-dhclient-utils.c
src/dhcp-manager/nm-dhcp-dhclient.c
src/dhcp-manager/nm-dhcp-dhcpcd.c
src/dhcp-manager/nm-dhcp-helper.c
src/dhcp-manager/nm-dhcp-listener.c
src/dhcp-manager/nm-dhcp-manager.c
src/dhcp-manager/nm-dhcp-systemd.c
src/dhcp-manager/nm-dhcp-utils.c
src/dhcp-manager/tests/test-dhcp-dhclient.c
src/dhcp-manager/tests/test-dhcp-utils.c
src/dns-manager/nm-dns-dnsmasq.c
src/dns-manager/nm-dns-manager.c
src/dns-manager/nm-dns-plugin.c
src/dns-manager/nm-dns-unbound.c
src/dns-manager/nm-dns-utils.c
src/dnsmasq-manager/nm-dnsmasq-manager.c
src/dnsmasq-manager/nm-dnsmasq-utils.c
src/dnsmasq-manager/tests/test-dnsmasq-utils.c
src/main-utils.c
src/main.c
src/nm-activation-request.c
src/nm-active-connection.c
src/nm-audit-manager.c
src/nm-auth-manager.c
src/nm-auth-subject.c
src/nm-auth-subject.h
src/nm-auth-utils.c
src/nm-bus-manager.c
src/nm-bus-manager.h
src/nm-config-data.c
src/nm-config.c
src/nm-connection-provider.c
src/nm-connectivity.c
src/nm-dcb.c
src/nm-default-route-manager.c
src/nm-dhcp4-config.c
src/nm-dhcp6-config.c
src/nm-dispatcher.c
src/nm-exported-object.c
src/nm-firewall-manager.c
src/nm-iface-helper.c
src/nm-ip4-config.c
src/nm-ip6-config.c
src/nm-logging.c
src/nm-manager.c
src/nm-multi-index.c
src/nm-policy.c
src/nm-rfkill-manager.c
src/nm-route-manager.c
src/nm-session-monitor.c
src/nm-sleep-monitor-systemd.c
src/nm-sleep-monitor-upower.c
src/platform/nm-fake-platform.c
src/platform/nm-linux-platform.c
src/platform/nm-platform-utils.h
src/platform/nm-platform.c
src/platform/nmp-object.c
src/platform/tests/monitor.c
src/platform/tests/test-address.c
src/platform/tests/test-cleanup.c
src/platform/tests/test-common.c
src/platform/tests/test-link.c
src/platform/tests/test-nmp-object.c
src/platform/tests/test-route.c
src/platform/wifi/wifi-utils-nl80211.c
src/platform/wifi/wifi-utils-wext.c
src/platform/wifi/wifi-utils.c
src/ppp-manager/nm-ppp-manager.c
src/ppp-manager/nm-pppd-plugin.c
src/rdisc/nm-fake-rdisc.c
src/rdisc/nm-lndp-rdisc.c
src/rdisc/nm-rdisc.c
src/rdisc/tests/test-rdisc-fake.c
src/rdisc/tests/test-rdisc-linux.c
src/settings/nm-agent-manager.c
src/settings/nm-inotify-helper.c
src/settings/nm-secret-agent.c
src/settings/nm-settings-connection.c
src/settings/nm-settings-plugin.c
src/settings/nm-settings.c
src/settings/plugins/ibft/nm-ibft-connection.c
src/settings/plugins/ibft/plugin.c
src/settings/plugins/ibft/reader.c
src/settings/plugins/ibft/tests/test-ibft.c
src/settings/plugins/ifcfg-rh/nm-ifcfg-connection.c
src/settings/plugins/ifcfg-rh/plugin.c
src/settings/plugins/ifcfg-rh/reader.c
src/settings/plugins/ifcfg-rh/shvar.c
src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh-utils.c
src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c
src/settings/plugins/ifcfg-rh/utils.c
src/settings/plugins/ifcfg-rh/writer.c
src/settings/plugins/ifnet/connection_parser.c
src/settings/plugins/ifnet/net_parser.c
src/settings/plugins/ifnet/net_utils.c
src/settings/plugins/ifnet/nm-ifnet-connection.c
src/settings/plugins/ifnet/plugin.c
src/settings/plugins/ifnet/tests/test-ifnet.c
src/settings/plugins/ifnet/wpa_parser.c
src/settings/plugins/ifupdown/interface_parser.c
src/settings/plugins/ifupdown/nm-ifupdown-connection.c
src/settings/plugins/ifupdown/parser.c
src/settings/plugins/ifupdown/plugin.c
src/settings/plugins/ifupdown/tests/test-ifupdown.c
src/settings/plugins/keyfile/nm-keyfile-connection.c
src/settings/plugins/keyfile/plugin.c
src/settings/plugins/keyfile/reader.c
src/settings/plugins/keyfile/tests/test-keyfile.c
src/settings/plugins/keyfile/utils.c
src/settings/plugins/keyfile/writer.c
src/supplicant-manager/nm-supplicant-config.c
src/supplicant-manager/nm-supplicant-interface.c
src/supplicant-manager/nm-supplicant-manager.c
src/supplicant-manager/nm-supplicant-settings-verify.c
src/supplicant-manager/tests/test-supplicant-config.c
src/systemd/nm-sd-adapt.c
src/systemd/nm-sd-adapt.h
src/tests/config/nm-test-device.c
src/tests/config/test-config.c
src/tests/test-dcb.c
src/tests/test-general-with-expect.c
src/tests/test-general.c
src/tests/test-ip4-config.c
src/tests/test-ip6-config.c
src/tests/test-resolvconf-capture.c
src/tests/test-route-manager.c
src/tests/test-utils.c
src/tests/test-wired-defname.c
src/vpn-manager/nm-vpn-connection.c
src/vpn-manager/nm-vpn-manager.c