Revert "ppp-manager: don't use kernel pppoe (rh #1034860, rh #1061641)"
authorDan Williams <dcbw@redhat.com>
Wed, 18 Feb 2015 16:45:07 +0000 (10:45 -0600)
committerBeniamino Galvani <bgalvani@redhat.com>
Wed, 13 May 2015 11:29:38 +0000 (13:29 +0200)
commit6fdfb03107138e96e641d12a7c4df5ecfacb5406
tree7dc57d548f2d902cb9ad75a0c2352f021ca0f787
parent0a04be41d4c08adb4eb5349201ca29562d061b89
Revert "ppp-manager: don't use kernel pppoe (rh #1034860, rh #1061641)"

We switched to user-mode PPPoE client to work around a bug in kernel
PPPoE code that caused pppd not to be notified when the connection was
terminated with a PADT before the LCP Termination Request.

The kernel bug has now been fixed upstream with commit 287f3a943fef
"pppoe: Use workqueue to die properly when a PADT is received", queued
for v4.1.

Since the issue affected only very particular scenarios and could
somehow be solved with the right configuration (see bugzilla entry),
we can safely revert the patch and restore the use of kernel mode
PPPoE.

This reverts commit 7955806a02db64b20079267743056d7d9d45af3b.

https://bugzilla.gnome.org/show_bug.cgi?id=742939
configure.ac
src/ppp-manager/nm-ppp-manager.c